feat(explorer): use tempo address activity api for history#849
feat(explorer): use tempo address activity api for history#849
Conversation
Bundle Size Report
Chunk changes (>1KB)
Compared against main branch (baseline from 2/4/2026, 5:13:51 PM) |
Cloudflare Deployments
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64f76b8ef4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const searchParams = new URLSearchParams({ | ||
| include: params.include, | ||
| includes: 'zones,transfers', | ||
| limit: params.limit.toString(), | ||
| offset: params.offset.toString(), |
There was a problem hiding this comment.
Although the route still accepts sort and computes sortDirection, the activity API request never includes sort information, so the response order falls back to the upstream default. As a result, ?sort=asc no longer yields ascending history whenever TEMPO_API_KEY is configured, which breaks ordering consistency versus the existing fallback query path and can invalidate offset-based pagination expectations.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec0d6dd386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const hasMore = | ||
| filteredItems.length > params.offset + params.limit || countCapped |
There was a problem hiding this comment.
In the filtered Tempo API path, hasMore is forced true whenever countCapped is true. At the boundary where sourceOffset reaches HISTORY_COUNT_MAX but the API already reports no additional source pages, this returns hasMore: true even though no more filtered items exist, which can lead clients to paginate into empty pages indefinitely for status/after queries.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 493a7254b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (val === undefined) { | ||
| return { txs: true, transfers: true, emitted: false } | ||
| } |
There was a problem hiding this comment.
sources to standard history sources
Handle ?sources= the same way as an omitted sources parameter. With the new val === undefined check, an empty string now produces { txs: false, transfers: false, emitted: false }, and the history route returns no transactions even when activity exists. This regresses prior behavior (if (!val)) and affects clients that send an empty query value instead of omitting the parameter.
Useful? React with 👍 / 👎.
1 participant
Summary
TEMPO_API_KEYto explorer env exampleValidation
Notes
0x35d01486dd24248e9d642b21732799c3cd89e6f8